rules_jvm_external icon indicating copy to clipboard operation
rules_jvm_external copied to clipboard

Duplicate artifact check does not handle trailing periods.

Open uri-canva opened this issue 1 year ago • 1 comments

Input artifacts:


    maven.artifact(
        group = "org.redisson",
        artifact = "redisson",
        version = "3.15.6",
    ),
    maven.artifact(
        group = "org.redisson.",
        artifact = "redisson",
        version = "3.20.1",
    ),

Output lock file:


            {
                "coord": "org.redisson.:redisson:3.20.1",

            {
                "coord": "org.redisson:redisson:3.15.6",

Output build file:


jvm_import(
	name = "org_redisson__redisson",

jvm_import(
	name = "org_redisson_redisson",

Output pinned repositories:


    http_file(
        name = "org_redisson__redisson_3_20_1",
        sha256 = "44ed221acd9201fc3a6abfe7f5f4b12aa666a15e69728191ae95526ffa5c6389",
        netrc = "../maven/netrc",
        urls = ["https://repo.maven.apache.org/maven2/org/redisson/redisson/3.20.1/redisson-3.20.1.jar"],
        downloaded_file_path = "v1/https/repo.maven.apache.org/maven2/org/redisson/redisson/3.20.1/redisson-3.20.1.jar",
    )

    http_file(
        name = "org_redisson_redisson_3_15_6",
        sha256 = "eabf4543078c6db940eecf07cbfefc1e35801baa29fb6967779437542bb9827d",
        netrc = "../maven/netrc",
        urls = ["https://repo.maven.apache.org/maven2/org/redisson/redisson/3.15.6/redisson-3.15.6.jar"],
        downloaded_file_path = "v1/https/repo.maven.apache.org/maven2/org/redisson/redisson/3.15.6/redisson-3.15.6.jar",
    )

note the extra underscore.

I can't find out whether the trailing period not breaking the resolution in coursier is intended or a bug, and I don't know enough scala to verify that in the source.

uri-canva avatar May 17 '23 03:05 uri-canva

Looks like it's a maven thing? Working as intended? 😆 https://stackoverflow.com/questions/24962607/multiple-versions-of-the-same-dependency-in-maven/53280462#53280462

uri-canva avatar May 17 '23 06:05 uri-canva