rules_jvm_external icon indicating copy to clipboard operation
rules_jvm_external copied to clipboard

Extra maven artifacts support for java_export rule

Open krisnaru opened this issue 2 years ago • 7 comments

Issue: Java_export needs to upload multiple artifacts as part of single rule. Artifacts could be war/tar files and it needs to support classifier.

Example: BUILD: java_export( name = "example-export", extra_artifacts = { "release": "//src/main/java/com/github/bazelbuild/rulesjvmexternal/example/export:tar", }, maven_coordinates = "com.example:bazel-example:0.0.1", runtime_deps = [ "//src/main/java/com/github/bazelbuild/rulesjvmexternal/example/export", ], )

bazel run -define "maven_repo=file://$HOME/.m2/repository" :example-export.publish

krisnaru avatar Dec 10 '22 21:12 krisnaru

@cheister I have made one more commit towards templating maven coordinates. Could you please check?

krisnaru avatar Dec 12 '22 04:12 krisnaru

@cheister could you please review and approve if you are fine with changes

krisnaru avatar Dec 20 '22 22:12 krisnaru

@cheister could you please review and approve if you are fine with changes

krisnaru avatar Jan 04 '23 05:01 krisnaru

@krisnaru, can I help you in any way to get this one over the line? It'd be lovely to have this in the tree....

shs96c avatar Mar 07 '23 16:03 shs96c

I have continued the work in this PR in #926 .

thirtyseven avatar Jun 29 '23 09:06 thirtyseven

Is there any intention/support for extra classifier artifacts being in the BOM too? Would be useful for things like test-jars that sometime get published and depended on.

cjohnstoniv avatar Aug 29 '23 01:08 cjohnstoniv

Is there any intention/support for extra classifier artifacts being in the BOM too? Would be useful for things like test-jars that sometime get published and depended on.

@cjohnstoniv We didn't need that for our use team's use case, but I'm sure it would make sense to extend this to the BOM if you want to contribute a PR.

thirtyseven avatar Aug 30 '23 23:08 thirtyseven