rules_jvm_external icon indicating copy to clipboard operation
rules_jvm_external copied to clipboard

Published 20 hours ago • verified publisher icon bazelbuild

Strip username from pinned urls

Open brujoand opened this issue 2 years ago • 1 comments

As described in #574 there is a situation where we depend on a private repository which requires authentication, and that authentication is provided through coursier properties files. In this case it's not ideal that the username of the person who performed a pinning is present in both the file and url attributes stored in the pinned json file. This creates quite a bit of noise when reviewing changes.

This PR attempts to clean away this string without affecting other authentication flows. I'm fairly new to starlark and this project in particular so it's very possible that I've overlooked potential side effects. PTAL

brujoand avatar Oct 14 '22 09:10 brujoand

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 14 '22 09:10 google-cla[bot]

Does this work when using an unpinned maven repo that requires authentication?

shs96c avatar Oct 20 '22 15:10 shs96c

I ran some more test and I updated my WORKSPACE so that I had

  • A repo which was unpinned targeting "https://repo1.maven.org/maven2"
  • A repo which was unpinned targeting a private repository
  • A repo which was pinned targeting "https://repo1.maven.org/maven2"
  • A repo which was pinned targeting a private repository

All repos could be fetched, even after a bazel clean --expunge.

brujoand avatar Oct 21 '22 08:10 brujoand