rules_jvm_external icon indicating copy to clipboard operation
rules_jvm_external copied to clipboard

Published 20 hours ago • verified publisher icon bazelbuild

chore: upgrade to rules_js

Open alexeagle opened this issue 1 year ago • 5 comments

This is lazy and won't fetch any packages from npm when the loading phase visits scripts/BUILD

alexeagle avatar Sep 20 '22 05:09 alexeagle

Failing because rules_js requires Bazel 5. @jin do you have a policy for when r_jvm_e will drop support for Bazel 4?

alexeagle avatar Sep 20 '22 05:09 alexeagle

We don't have concrete plans to drop backwards compat yet. Is this a necessary change?

jin avatar Sep 20 '22 05:09 jin

We only include the JS rules so we can run doctoc when we update our documentation. I don't think we need to change the version of Bazel we're using to support that, since we so seldom run this part of the build.

Also, I'd prefer to hold on until Bazel 6 for an upgrade to rules_js since that's when it'll start working with remote builds.

shs96c avatar Sep 20 '22 11:09 shs96c

Not necessary at all, I was just driving by. Thanks!

alexeagle avatar Sep 20 '22 15:09 alexeagle

It's appreciated :) I'm looking forward to picking up rules_js when we can!

shs96c avatar Sep 21 '22 11:09 shs96c