rules_jvm_external icon indicating copy to clipboard operation
rules_jvm_external copied to clipboard
verified publisher icon bazelbuild

Fix coursier credentials

Open lgzy opened this issue 3 years ago • 5 comments

Changes _repository_credentials to return a string surrounded with quotes as the result is passed to commandline as one of parameters in the form of ... --credentials <result string> and ends up being incorrectly parsed. The quotes enable it to be correctly parsed.

lgzy avatar May 16 '22 10:05 lgzy

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar May 16 '22 10:05 google-cla[bot]

Sorry for the slow response to your initial PR --- I missed this in my reviews, and only just saw it. I appreciate your patience!

shs96c avatar Jul 05 '22 12:07 shs96c

fixed the offending test. The current failures don't seem to be relevant?

lgzy avatar Jul 08 '22 14:07 lgzy

@lgzy can you rebase this PR on latest master?

pcj avatar Oct 24 '22 22:10 pcj

I believe this was fixed with https://github.com/bazelbuild/rules_jvm_external/pull/721 ?

cheister avatar Dec 03 '22 01:12 cheister