rules_jvm_external
rules_jvm_external copied to clipboard
Repo names incorrectly being generated with maven overrides
Found another edge case while testing this PR out.
ERROR: no such package '@@[unknown repo 'com_google_android_gms_play_services_tasks_18_1_0' requested from @@_main~maven~from_files (did you mean 'com_google_android_gms_play_services_tasks_aar_18_1_0'?)]//file': The repository '@@[unknown repo 'com_google_android_gms_play_services_tasks_18_1_0' requested from @@_main~maven~from_files (did you mean 'com_google_android_gms_play_services_tasks_aar_18_1_0'?)]' could not be resolved: No repository visible as '@com_google_android_gms_play_services_tasks_18_1_0' from repository '@@_main~maven~from_files'
Steps to reproduce
Add this dependency to the toml file:
# This demonstrates a dependency override
com-google-android-recaptcha-recaptcha = { module = "com.google.android.recaptcha:recaptcha", package = "aar", version = "18.4.0" }
Add this to the MODULE.bazel:
http_file(
name = "com_google_android_recaptcha_recaptcha",
sha256 = "0eba91a3d66a1035d390914bd4304b828f09491102befc9ded6a612affff1945",
urls = ["https://dl.google.com/android/maven2/com/google/android/recaptcha/recaptcha/18.7.1/recaptcha-18.7.1.aar"],
)
...
maven.override(
name = "instantandroid_maven",
coordinates = "com.google.android.recaptcha:recaptcha",
target = "@//third_party/com.google.android.recaptcha:recaptcha",
)
And then run:
REPIN=1 bazel run @from_files//:pin && bazel build @from_files//:all