rules_jvm_external icon indicating copy to clipboard operation
rules_jvm_external copied to clipboard

Add no-remote-cache tags to intermediate artifacts so rules_jvm_external works with --remote_download_toplevel set

Open cheister opened this issue 2 years ago • 2 comments

When updating to Bazel 7.0.0 the default Build without the Bytes (BwoB) setting goes from --remote_download_all to --remote_download_toplevel. For our build, this started breaking the intermediate jars used by rules_jvm_external and we had to go back to --remote_download_all to have them work. In our case, if we did a bazel clean then a bazel build it would not find the intermediate jar targets used by rules_jvm_external.

This change fixes rules_jvm_external when --remote_download_toplevel is set but I'm not sure if this is the correct fix or not. I'm looking for input if there might be another way to keep it working. Bazel common cache tags reference is here

cheister avatar Jan 14 '24 21:01 cheister

Gently pushing back on this. We've been using BwoB at work for some time, and haven't seen this problem.

Is this happening on the command line builds? Or somewhere else (perhaps in the IDE integration?) Normally, you won't need to download intermediate artifacts, but perhaps you're doing something after the build that needs them?

Would the remote_download_regex in your project repo be sufficient?

shs96c avatar Jan 15 '24 12:01 shs96c

Is this happening on the command line builds? Or somewhere else (perhaps in the IDE integration?) Normally, you won't need to download intermediate artifacts, but perhaps you're doing something after the build that needs them?

This is all command line. I'll keep looking, I'm not sure what would need these intermediate artifacts in the build.

cheister avatar Jan 15 '24 19:01 cheister