rules_go icon indicating copy to clipboard operation
rules_go copied to clipboard

Only use workaround for darwin deadlock on darwin

Open mbeards opened this issue 2 years ago • 1 comments

What type of PR is this? Bug fix

What does this PR do? Why is it needed? Only use the workaround from https://github.com/bazelbuild/rules_go/pull/3536 on darwin.

(The lack of parallelism here makes this step heavy in the critical path for some of our builds.)

mbeards avatar Nov 28 '23 04:11 mbeards

As this is only used for certain special binaries that are typically built very early in a build, I am slightly surprised to see this contribute to your critical path. Are you able to share a profile (--profile) that we can use to understand this better?

Generally speaking, an action should really only use up a single CPU core, so this setting is correct on all platforms. But of course we don't want it to negatively affect performance.

fmeum avatar Nov 30 '23 07:11 fmeum