rules_foreign_cc icon indicating copy to clipboard operation
rules_foreign_cc copied to clipboard

Supporting Startfiles

Open DanielEliad opened this issue 2 years ago • 4 comments

Hey :) I tried compiling a libc using this repo but found out I can't use startfiles (crti.0, crt1.o, crtn.o) in targets that depend on my libc target.

So I added optional support for consuming generated startfiles

DanielEliad avatar Aug 09 '22 20:08 DanielEliad

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 09 '22 20:08 google-cla[bot]

I added some more documentation in the attribute doc As for the example I only came across this need when trying to compile uclibc would you like me to put my project in the examples/third_party here?

DanielEliad avatar Aug 10 '22 21:08 DanielEliad

the CI seems to have failed with a non related error:

2022/08/10 21:31:23 could not resolve the version 'latest' to an actual version number: unable to determine latest version: could not list available releases for 6.0.0: could not list GCS objects at https://www.googleapis.com/storage/v1/b/bazel/o?delimiter=/&prefix=6.0.0/release/: could not fetch https://www.googleapis.com/storage/v1/b/bazel/o?delimiter=/&prefix=6.0.0/release/: Get "https://www.googleapis.com/storage/v1/b/bazel/o?delimiter=/&prefix=6.0.0/release/": stream error: stream ID 3; INTERNAL_ERROR

DanielEliad avatar Aug 10 '22 21:08 DanielEliad

It seems the RBE build failed because the imported example build has a hardcoded reference to use gcc whereas the CC compiler is configured to clang. I'm guessing the kernel headers possibly don't compile with clang?

jsharpe avatar May 05 '23 20:05 jsharpe