rules_foreign_cc icon indicating copy to clipboard operation
rules_foreign_cc copied to clipboard

Fix pkgconfig_build.bzl for Windows build with Bzlmod

Open meteorcloudy opened this issue 1 year ago • 3 comments

Make sure repo names are generated correctly and toolchain label is passed instead of pure string.

Hopefully fixes https://github.com/bazelbuild/rules_foreign_cc/issues/1239

meteorcloudy avatar Jul 31 '24 12:07 meteorcloudy

We might want to actually enable bzlmod in CI for windows to test this!: https://github.com/bazelbuild/rules_foreign_cc/blob/fb209674f326b7020f64d5d022cbe7fa16f3209c/.bazelci/config.yaml#L31

jsharpe avatar Jul 31 '24 12:07 jsharpe

Just updating to latest main to get a clearer idea of what's broken in CI

jsharpe avatar Aug 08 '24 16:08 jsharpe

@jsharpe rules_foreign_cc 0.15.0 still has this issue Make.log

MiyamuraMiyako avatar Jul 22 '25 01:07 MiyamuraMiyako