rules_foreign_cc icon indicating copy to clipboard operation
rules_foreign_cc copied to clipboard

Allow binaries without any shared libraries to be used for runnable_binary

Open rueteh opened this issue 2 years ago • 1 comments

When using the runnable_binary macro with a binary e.g. diff that does not involve any shared libraries, the following error is produced:

line 46: SHARED_LIBS_ARRAY[@]: unbound variable

As find . -name "*${SHARED_LIB_SUFFIX}" -print0 does not return any results (thus SHARED_LIBS_ARRAY) , along with set -uo earlier in the script, this assumes that there will always be some shared library files.

This PR bring the set +u command earlier to allow the variable to be empty if there are only static libraries involved.

rueteh avatar Sep 14 '23 04:09 rueteh

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 14 '23 04:09 google-cla[bot]