rules_foreign_cc icon indicating copy to clipboard operation
rules_foreign_cc copied to clipboard
verified publisher icon bazelbuild

Make pkgconfig Hermetic

Open dstufft opened this issue 2 years ago • 1 comments

Make sure that when building pkg-config, that we're using the make and other tools from our configured toolchain rather than using whatever we happen to find on $PATH.

Fixes #1065

dstufft avatar Jun 29 '23 00:06 dstufft

Hmm, I don't know enough about macOS to understand why exactly it's failing here

dstufft avatar Jun 29 '23 02:06 dstufft

Hmm, I don't know enough about macOS to understand why exactly it's failing here

For some reason the ARFLAGS are not passed:


CC       libcharset_la-localcharset.lo
--
  | CCLD     libcharset.la
  | error: /Applications/Xcode14.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: no output file specified (specify with -o output)

I can repro it locally.

steeve avatar Mar 07 '24 22:03 steeve

@dstufft We are currently setting AR to an empty string in the environment variables, that seems to work (not sure why). Would that be a proper fix?

See: https://github.com/bazelbuild/rules_foreign_cc/commit/48d7b9fa84fef6c2c58f810fa629c39e2572125b

dmeijboom avatar Mar 15 '24 09:03 dmeijboom

would be nice to have a release with this one

keith avatar Jul 02 '24 19:07 keith

would be nice to have a release with this one

I'll try and cut a release today..

jsharpe avatar Jul 03 '24 08:07 jsharpe

Annoyingly the CI job for the release process failed; I don't currently have time to debug this - the tag is present on the repo so you can reference that release but cutting the release to the BCR will have to be more manual..

jsharpe avatar Jul 03 '24 22:07 jsharpe

Actually turned out to be quite straightforward - 0.11.1 should be in the BCR once it's been reviewed there.

jsharpe avatar Jul 04 '24 08:07 jsharpe