rules_dotnet icon indicating copy to clipboard operation
rules_dotnet copied to clipboard

[Next] Update rules-proto-grpc once next branch is merged

Open aaliddell opened this issue 4 years ago • 5 comments

In recent versions you've switched to using toolchains and platforms for selecting the SDK version to be used. However, using a platform to resolve a single field in the toolchain is somewhat problematic for anyone who already has an existing platform, since it necessarily won't know about the SDK version.

Why were the config_settings not applied directly as constraints on the toolchain, rather than indirectly via the platforms? e.g bazel build //... --@io_bazel_rules_dotnet//dotnet/toolchain:sdk_version=3.1.100 along with target_settings on the toolchain definitions to restrict the resolved toolchain to one that matches the SDK version config setting.

aaliddell avatar Feb 19 '21 14:02 aaliddell

@aaliddell Do you have some examples of toolchains that are configured this way? E.g. how do I make a constraint conifgurable via a flag?

purkhusid avatar Apr 03 '21 21:04 purkhusid

And also, is it possible to use incompatible target skipping when using the approach you mentioned? E.g. in the repo there are targets that are only compatible with certain SDK versions.

purkhusid avatar Apr 03 '21 22:04 purkhusid

These flags will be removed when we merge the next branch. I'm going to change this issue to track updating rules-proto-grpc once the next branch has been merged

purkhusid avatar Aug 05 '22 12:08 purkhusid

Hello, is this issue about updating rules-proto-grpc so that the csharp-grpc-library etc. all work on the new @rules_dotnet instead of io_bazel_rules_dotnet?

Place1 avatar Feb 23 '23 03:02 Place1

Yes, we need to update rules_proto_grpc to use the latest release because we did multiple breaking changes recently

purkhusid avatar Feb 23 '23 06:02 purkhusid

Closing this. These rules and rules_proto_grpc have changed significantly since it was created.

purkhusid avatar Apr 03 '24 15:04 purkhusid