rules_docker icon indicating copy to clipboard operation
rules_docker copied to clipboard

Support push_targets in container_bundle

Open codersasha opened this issue 2 years ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

container_bundle only supports a strange dictionary format for images.

What is the new behavior?

container_bundle can take a push_targets parameter, and the info for the image (repository, tag, etc) is taken from existing push rules. This also means contains_bundle supports using tag_files, and the subsequent push-all rule can push using these tag files as well.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

codersasha avatar May 09 '23 00:05 codersasha

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

github-actions[bot] avatar Dec 10 '24 02:12 github-actions[bot]