rules_docker icon indicating copy to clipboard operation
rules_docker copied to clipboard

Add timeout for attr for `dockerfile_image`.

Open charlesoconor opened this issue 1 year ago • 1 comments

Some build take longer than 10 minutes since this doesn't use the docker cache so larger images can be slow.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [x] Feature
  • [x] Code style update (formatting, local variables)
  • [x] Refactoring (no functional changes, no api changes)
  • [x] Build related changes
  • [x] CI related changes
  • [x] Documentation content changes
  • [x] Other... Please describe:

What is the current behavior?

Currently the dockerfile_image will timeout after 10 minutes. Since there isn't a cache larger images builds can take longer than that especially on slow networks.

Issue Number: N/A

What is the new behavior?

This adds the option to set a higher timeout for the action.

Does this PR introduce a breaking change?

dockerfile_build

  • No

charlesoconor avatar Mar 07 '23 03:03 charlesoconor

Any idea when people might look at this? can close if it doesn't make sense, but I would like to know why.

charlesoconor avatar Jun 09 '23 22:06 charlesoconor