rules_docker icon indicating copy to clipboard operation
rules_docker copied to clipboard

Update `nodejs_image` repository settings to match current latest version of `rules_nodejs`

Open codersasha opened this issue 3 years ago • 0 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [X] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #2078

What is the new behavior?

See issue for more details.

Does this PR introduce a breaking change?

  • [X] Yes
  • [ ] No

Removes the include_node_repo_args argument, which will break rules that use it. But this is probably only used for rules that disable it, so it'll be good for those rules to remove it when they update.

Remove the include_node_repo_args = False flag, which most repos include to fix this bug, and is no longer needed now that the bug is actually fixed.

Other information

codersasha avatar Jul 17 '22 03:07 codersasha