rules_docker icon indicating copy to clipboard operation
rules_docker copied to clipboard

Disable cache for install_pkgs_reproducibility_test deps

Open laurynaslubys opened this issue 3 years ago • 1 comments

Docker rules are not hermetic as the sha of layers depends on the modification times of files inside containers. If the the containers get cached from different runs, they will have different sha sums.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Some PRs (#1439 #2068) are blocked on //tests/docker/package_managers:install_pkgs_reproducibility_test failing.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

laurynaslubys avatar Apr 25 '22 13:04 laurynaslubys

This may have accidentally been caused by #2043

laurynaslubys avatar Apr 25 '22 15:04 laurynaslubys

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

github-actions[bot] avatar Oct 23 '22 03:10 github-actions[bot]

This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

github-actions[bot] avatar Nov 23 '22 02:11 github-actions[bot]