rules_docker icon indicating copy to clipboard operation
rules_docker copied to clipboard

Upgrade rules_go and Gazelle

Open linzhp opened this issue 4 years ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [x] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

rules_go and Gazelle are pretty old

Issue Number: #2036

What is the new behavior?

  • Upgrade rules_go to 0.30
  • Upgrade Gazelle to 0.24
  • Upgrade Bazel to 5.0, because rules_go requires Bazel 4.2.1

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

New rules_go no longer allows to call go_register_toolchains multiple times, so we have to move it out of go_deps, because it will be called another time in python/image.bzl.

linzhp avatar Mar 01 '22 15:03 linzhp

FWIW: I'm currently using this on an M1 Mac to successfully cross-compile linux_amd64 containers using Bazel 4.2.2

ricochet1k avatar Jun 28 '22 16:06 ricochet1k

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

github-actions[bot] avatar Dec 26 '22 02:12 github-actions[bot]

This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

github-actions[bot] avatar Jan 25 '23 02:01 github-actions[bot]

Why is this PR close? people using M1 host seem to have issues with it.

thesayyn avatar Feb 28 '23 14:02 thesayyn