rules_docker icon indicating copy to clipboard operation
rules_docker copied to clipboard

forward $@ through push-all.bzl to the pusher command

Open zevdg opened this issue 3 years ago • 1 comments

This has always been done in push.bzl (via push-tag.sh.tpl). Just making push-all.bzl consistent.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Aribtrary flags can now be passed to the pusher through push-all.bzl

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

zevdg avatar Feb 10 '22 23:02 zevdg

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

github-actions[bot] avatar Aug 10 '22 02:08 github-actions[bot]

This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

github-actions[bot] avatar Sep 09 '22 03:09 github-actions[bot]