bazelbuild
Propagate new values for stamping introduced in 0.22.0 to language rules
🚀 feature request
Relevant Rules
All languages rules (<language>_image).
Description
Version 0.22.0 introduced new values for stamping (stamp:always, stamp:never, and stamp:use_stamp_flag) for the basic rules via https://github.com/bazelbuild/rules_docker/pull/1878/. However, the language rules were not updated and are still using the old stamping values (True and False).
For images generated via language rules, stamping for the Docker part can only be controlled via --stamp. For example, java_image is a macro that calls rules java_binary and jar_app_layer. jar_app_layer reuses container_image. Since this call to container_image doesn't provide any stamp argument the implementation is using the default value (stamp:use_stamp_flag).
Describe the solution you'd like
All rules from rules_docker use the same values for stamping.
Yes, for sure, thank you for the description in the linked issue as well.
This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!
I don't particularly care about this anymore since we are now doing it another way but I think it shouldn't be closed.
This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!
This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"