rules_docker
rules_docker copied to clipboard
Use use_default_shell_env for tar
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
- [X] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
It's not possible to use $PATH
to override the path for tar,
so this patch adds use_default_shell_env
in order to allow
the user to override that.
Does this PR introduce a breaking change?
- [ ] Yes
- [x] No
Other information
Helps on environments running macOS
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!
LGTM.
@smukherj1, I wonder what's the use case of the @io_bazel_rules_docker//container:build_tar
? Should we use it instead of system tar
from the $PATH
?
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!
This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"