Release puller + loader binaries
PR Type
What kind of change does this PR introduce?
- [x] Feature
What is the current behavior?
We build and upload binaries to GCS with cloudbuild
Issue Number: #1794
What is the new behavior?
We build and upload binariies to GitHub with GitHub Actions
Does this PR introduce a breaking change?
- [ ] Yes
- [x] No
Other information
Closes https://github.com/bazelbuild/rules_docker/issues/1794
This is a bit gross, and janky, but it works: https://github.com/zoidbergwill/rules_docker/releases/tag/v0.0.0-deadbeef
Thanks @zoidbergwill this looks like a great start.
One thing we really need this for is the puller/loader to be precompiled against multiple architectures which is currently done by https://github.com/bazelbuild/rules_docker/blob/master/container/go/cloudbuild.yaml. These precompiled binaries are used by the pull.bzl repository rule (sort of a chicken-and-egg problem).
It would be awesome if you could extend this releaser PR to produce the binaries listed in that cloudbuild.yaml!
Hey @pcj! Thanks for the review!
I'm building the puller and loader binaries for darwin-x86_64 and linux-{amd64,arm64,s390x}, which I got from that cloudbuild.yaml.
I'll work on testing / updating repositories/repositories.bzl using binaries from GitHub instead of GCS.
Struggling to reproduce the Travis CI error to update the SHAs but will work on it tomorrow, and the buildkiite CI failure doesn't seem related.
(I tried bazel clean --expunge && bazel run "@loader_darwin//file:downloaded" and it still uses the cached versions)
@zoidbergwill any update on this?
I see this PR is still open. Would love to see it landed!
I can update this branch sometime and see if the CI passes now
I originally thought the CI failing wasn't related to my changes, but I think they might be.
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!
I'll try rebasing and seeing if I can figure out the CI failures tomorrow
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!
Hey @zoidbergwill i learned from this and rules_oci refuses to ship any binaries. Want to come contribute over there?
This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"
Hey @zoidbergwill i learned from this and rules_oci refuses to ship any binaries. Want to come contribute over there?
Yes!