rules_docker icon indicating copy to clipboard operation
rules_docker copied to clipboard

Release puller + loader binaries

Open zoidyzoidzoid opened this issue 4 years ago • 9 comments

PR Type

What kind of change does this PR introduce?

  • [x] Feature

What is the current behavior?

We build and upload binaries to GCS with cloudbuild

Issue Number: #1794

What is the new behavior?

We build and upload binariies to GitHub with GitHub Actions

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Closes https://github.com/bazelbuild/rules_docker/issues/1794

This is a bit gross, and janky, but it works: https://github.com/zoidbergwill/rules_docker/releases/tag/v0.0.0-deadbeef

zoidyzoidzoid avatar Mar 30 '21 20:03 zoidyzoidzoid

Thanks @zoidbergwill this looks like a great start.

One thing we really need this for is the puller/loader to be precompiled against multiple architectures which is currently done by https://github.com/bazelbuild/rules_docker/blob/master/container/go/cloudbuild.yaml. These precompiled binaries are used by the pull.bzl repository rule (sort of a chicken-and-egg problem).

It would be awesome if you could extend this releaser PR to produce the binaries listed in that cloudbuild.yaml!

pcj avatar Mar 31 '21 15:03 pcj

Hey @pcj! Thanks for the review!

I'm building the puller and loader binaries for darwin-x86_64 and linux-{amd64,arm64,s390x}, which I got from that cloudbuild.yaml.

I'll work on testing / updating repositories/repositories.bzl using binaries from GitHub instead of GCS.

zoidyzoidzoid avatar Apr 06 '21 14:04 zoidyzoidzoid

Struggling to reproduce the Travis CI error to update the SHAs but will work on it tomorrow, and the buildkiite CI failure doesn't seem related.

(I tried bazel clean --expunge && bazel run "@loader_darwin//file:downloaded" and it still uses the cached versions)

zoidyzoidzoid avatar Apr 06 '21 19:04 zoidyzoidzoid

@zoidbergwill any update on this?

pcj avatar May 26 '21 14:05 pcj

I see this PR is still open. Would love to see it landed!

shs96c avatar Sep 03 '21 16:09 shs96c

I can update this branch sometime and see if the CI passes now

zoidyzoidzoid avatar Jan 28 '22 09:01 zoidyzoidzoid

I originally thought the CI failing wasn't related to my changes, but I think they might be.

zoidyzoidzoid avatar Feb 13 '22 19:02 zoidyzoidzoid

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

github-actions[bot] avatar Aug 13 '22 03:08 github-actions[bot]

I'll try rebasing and seeing if I can figure out the CI failures tomorrow

zoidyzoidzoid avatar Aug 17 '22 20:08 zoidyzoidzoid

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

github-actions[bot] avatar Feb 27 '23 02:02 github-actions[bot]

Hey @zoidbergwill i learned from this and rules_oci refuses to ship any binaries. Want to come contribute over there?

alexeagle avatar Feb 27 '23 04:02 alexeagle

This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

github-actions[bot] avatar Mar 30 '23 02:03 github-actions[bot]

Hey @zoidbergwill i learned from this and rules_oci refuses to ship any binaries. Want to come contribute over there?

Yes!

zoidyzoidzoid avatar Jun 15 '23 07:06 zoidyzoidzoid