rules_closure icon indicating copy to clipboard operation
rules_closure copied to clipboard

Make rules_closure conform to Style Guide for Rules

Open Yannic opened this issue 4 years ago • 3 comments

Tracking bug for making rules_closure conform to Bazel's Style Guide for Rules.

Known issues:

  • [x] Dependencies / Toolchains should be declared by rules_closure_{dependencies,toolchains} in closure/repositories.bzl: https://docs.bazel.build/versions/master/skylark/deploying.html#dependencies
  • [ ] Tests should live in //tests
  • [x] Repo description should be Closure rules for Bazel
  • [ ] Workspace should be named rules_closure (Note: There are probably too many existing users now, so this is going to be a wontFix issue).

Yannic avatar Sep 14 '19 13:09 Yannic

@alexeagle Can you handle the repo description issue?

Yannic avatar Oct 18 '19 12:10 Yannic

Sure, done, thanks for picking this up.

alexeagle avatar Oct 18 '19 13:10 alexeagle

Thank you!

Yannic avatar Oct 18 '19 14:10 Yannic