rules_closure
rules_closure copied to clipboard
Add js output to list of files when being used as a filegroup
I've been using the closure_css_binary
rule in tandem with the resources
attribute of a java_library
rule. The name.css
and name.css.map
were being built into the jar correctly, but the name.css.js
file was missing:
META-INF/
META-INF/MANIFEST.MF
logback.xml
css/
css/circuitcanyon_css_bin.css
css/circuitcanyon_css_bin.css.map
Since I'd like to load the mappings into a Java backend for making a SoyCssRenamingMap
, I need this file to parse and render server side templates. This PR adds it to the file output:
META-INF/
META-INF/MANIFEST.MF
logback.xml
css/
css/circuitcanyon_css_bin.css
css/circuitcanyon_css_bin.css.map
css/circuitcanyon_css_bin.css.js
Can one of the admins verify this patch?
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
- If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
- In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
Just signed the CLA.
CLAs look good, thanks!
There hasn't been any activity in this PR for very long time. Please let me know if there are any intentions to pursue this change. Otherwise I will close it. Thanks.