rules_cc icon indicating copy to clipboard operation
rules_cc copied to clipboard

Update WORKSPACE to account for bazel_tool//platforms going away.

Open aiuto opened this issue 2 years ago • 2 comments

  • point to bazelbuild/platforms for @platforms
  • Use a newer version of rules_go for our internal rules.
  • Make a bzl file used in a test visible to the tests.

I believe this fixes a build breakage in bazel at head and 5.3.0 #140

cc: @aranguyen

aiuto avatar Aug 26 '22 19:08 aiuto

How do we get this merged?

Wyverald avatar Aug 31 '22 17:08 Wyverald

Ah, I see there are outstanding CI failures.

Wyverald avatar Aug 31 '22 17:08 Wyverald

I removed the debugging lines, but TBH, I'm not sure where I left this. I was unexpectedly OOO all of this week so far, and what happened last Friday is a distant memory. Let's see how CI goes.

aiuto avatar Sep 01 '22 16:09 aiuto

Gack!!!! We auto-pull? Someone else has to approve that.

aiuto avatar Sep 01 '22 16:09 aiuto

Ah.... even stranger, but we can discuss that offline. This needs another approve before it can merge.

aiuto avatar Sep 01 '22 18:09 aiuto