bazelbuild
Make test environment override test rule attr env and runner info
Currently test rule will respect test rule's env attribute over manual test_env specification, this seems a bit counter-intuitive when setting test environment explicitly like bazel test --test_env=FOO=BAR doesn't get what you want
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
I believe this is expected, this mirrors the behavior of defining copts on targets as well I think? For example if you have:
cc_library(
name = "counter",
srcs = ["counter.cc"],
hdrs = ["counter.h"],
copts = ["-DFOO"],
)
And run:
bazel build //:counter --copt=-DBAR -s
The invocation has -DBAR -DFOO, so if the args were competing the copts on cc_library would win.
Related tests which current encode the behavior I'm describing https://github.com/bazelbuild/rules_apple/pull/868