rules_apple icon indicating copy to clipboard operation
rules_apple copied to clipboard

Fix action_env for ipa post processor

Open MIP9 opened this issue 2 years ago • 10 comments

Environment variables that provided by --action_env flag are not accessible on ipa_post_processor .sh script.

There is fix for it.

MIP9 avatar Sep 04 '23 14:09 MIP9

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 04 '23 14:09 google-cla[bot]

@MIP9 Can you sign the CLA?

thii avatar Sep 05 '23 10:09 thii

Can you rebase off master? Looks like buildifier is reporting outdated warnings from an old revision.

Other CI issues are probably related to the current GitHub's incident.

thii avatar Sep 05 '23 13:09 thii

this is also being fixed in bazel with https://github.com/bazelbuild/bazel/pull/18235/

keith avatar Sep 05 '23 16:09 keith

@keith Does this PR still make sense? Or do you think better leave as is and wait for bazel 6.4.0?

acecilia avatar Sep 05 '23 21:09 acecilia

yea that's a good question, can you test with 6.4 and see if it really does fix it?

keith avatar Sep 05 '23 21:09 keith

Seems the cherrypick did not make it to 6.4.0 yet, and the commit has not been built with bazel ci (so there is no prebuilt bazel binary), so I am not sure how to test it atm 😅

acecilia avatar Sep 05 '23 21:09 acecilia

If you use bazelisk you can set last_green as a version and try that.

thii avatar Sep 06 '23 07:09 thii

Or build a bazel binary with that patch.

thii avatar Sep 06 '23 07:09 thii

note that with bazel 7.x HEAD of rules_apple now enables that env for all actions (or tries too, possible I missed some)

keith avatar Sep 20 '23 16:09 keith