rules_apple icon indicating copy to clipboard operation
rules_apple copied to clipboard

Add module name to the testrunner

Open dostrander opened this issue 3 years ago • 4 comments

If there are modules under the tests that are named differently then the target itself it will cause issues with the xctestrun file. Specifically using Swift the test_filters do not work unless the module names line up with the test target name. Guessing because Swift's full class names are MODULE.CLASS so they do the magic under the hood.

We'll likely need to wait until https://github.com/google/xctestrunner/pull/50 is merged

dostrander avatar Dec 09 '22 19:12 dostrander

can you throw a value for this attr into one of the test targets so that it actually gets caught by CI? also note that this has to hit master before this branch, we won't ever merge this branch back into master

keith avatar Dec 09 '22 19:12 keith

can you throw a value for this attr into one of the test targets so that it actually gets caught by CI? also note that this has to hit master before this branch, we won't ever merge this branch back into master

Will do.

Also open to possibly changing this name to module_name or something. I keep going back and forth in my head

dostrander avatar Dec 09 '22 19:12 dostrander

@dostrander bump - I think there's a few test failures that would prevent us from landing this re: https://github.com/bazel-ios/rules_ios/pull/663

jerrymarino avatar Feb 27 '23 22:02 jerrymarino

@dostrander bump - I think there's a few test failures that would prevent us from landing this re: bazel-ios/rules_ios#663

This can't realyl be merged until https://github.com/google/xctestrunner/pull/50 is merged unless we do a patch

dostrander avatar Feb 28 '23 13:02 dostrander