rules_appengine icon indicating copy to clipboard operation
rules_appengine copied to clipboard

Address post-merge comments on PR #71

Open jo2y opened this issue 7 years ago • 2 comments

  • Quote bash variable when possible.
  • Fix an undefined $root_dir
  • Remove a redundant rm and let the defined trap handler do it.
  • echo -e is needed when trying to display escape codes.
  • Remove incorrect {{foo}} double curly braces.

jo2y avatar Apr 01 '18 20:04 jo2y

@rogerhub Take a look please. I resisted the urge to change all of the $foo to ${foo} because I'm not sure if there is an official style. I stuck with the majority existing style.

jo2y avatar Apr 01 '18 20:04 jo2y

Hi, is anyone still looking at this? The python .deploy commands are currently broken.

jdelfino avatar Aug 15 '18 16:08 jdelfino