bazelbuild
Add max_cas_blob_size_bytes to CacheCapabilities message (continuation)
Continuing the work from https://github.com/bazelbuild/remote-apis/pull/278
@bergsieker may I ask you to review this PR? It's the continuation of https://github.com/bazelbuild/remote-apis/pull/278, which you already reviewed once
I wonder if there is a value that can be added to the spec that would have solved my issue as well https://github.com/bazelbuild/remote-apis/issues/297
Some context: our server has a fine-grained access level for each API key, and one level could grant CAS-readonly and reject all uploads. So with this change, I can see a quick hack where we set the value to 1 byte to signal the client to skip all uploads. But if there is a -1 value added to the spec, I think it would be better.
I wonder if there is a value that can be added to the spec that would have solved my issue as well #297
Some context: our server has a fine-grained access level for each API key, and one level could grant CAS-readonly and reject all uploads. So with this change, I can see a quick hack where we set the value to 1 byte to signal the client to skip all uploads. But if there is a
-1value added to the spec, I think it would be better.
I think it would be better to keep "permission" separate from "limits." Presumably you want to have some client-side logic that says something like "These blobs should be uploaded if possible, but it's not an error if I can't upload them because I don't have permission." That's pretty different from "These blobs should be uploaded if possible, but if the CAS can't support them don't trigger an error."
