intellij icon indicating copy to clipboard operation
intellij copied to clipboard

Add RadBazelProjectFallbackConfigDisabler

Open LeFrosch opened this issue 3 weeks ago • 3 comments

We found that providing fallback configuration to backend leads to recursive watch roots being set up for include paths mentioned in the fallback config. We know this has very negative performance implications because of greediness in VfsWarmQueue. This extension point allows us to disable fallback configurations for Bazel projects. (commit message from @ujohnny)

However, since the extension point was introduced in 2025.2.5, it is not save to simply instantiate the implementation class and we need to do some manual registration magic.

LeFrosch avatar Dec 10 '25 16:12 LeFrosch

Summary of Changes

Hello @LeFrosch, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial performance optimization for Bazel projects by preventing the creation of recursive file system watch roots that arise from fallback configurations. It achieves this by adding a new extension point to disable these configurations specifically for Bazel projects. To maintain compatibility with various CLion versions, a dynamic registration mechanism is employed, ensuring the feature works correctly even in older environments where the extension point might not be natively present. The changes also include updates to core utility services and build configurations to support this new functionality.

Highlights

  • Performance Improvement: Addresses a performance issue in Bazel projects caused by recursive watch roots from fallback configurations, specifically impacting VfsWarmQueue.
  • New Extension Point: Introduces RadBazelProjectFallbackConfigDisabler to selectively disable fallback configurations for Bazel projects.
  • Backward Compatibility: Implements RadBazelProjectFallbackConfigRegister to dynamically register the disabler, ensuring compatibility with CLion versions older than 2025.2.5 where the extension point might not be directly available.
  • Disposable Utility: Enhances ScopeService.kt to provide Disposable instances for project and application scopes, facilitating proper lifecycle management for the new registration logic.
  • Build System & SDK Updates: Modifies Bazel build files to include necessary clion-radler plugin JARs and updates SDK compatibility layers to define the RadProjectFallbackConfigDisabler interface across different CLion versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 10 '25 16:12 gemini-code-assist[bot]

@LeFrosch did you verify the change in the behavior with reported watchroots?

ujohnny avatar Dec 11 '25 08:12 ujohnny

did you verify the change in the behavior with reported watchroots?

@ujohnny no, not yet. Will do so tomorrow. Let's wait with merging until then.

LeFrosch avatar Dec 11 '25 08:12 LeFrosch