Fix NPE in RadTestContextProviderKt.chooseTargetForFile

[ujohnny]

For some reason in Java/Kotlin interop a nullable type was visible as non-nullable in kotlin, so this led to unexpected NPE in code. Fixed with proper annotations on the Java side and adjusted the documentation.

[gemini-code-assist[bot]]

Summary of Changes

Hello @ujohnny, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a NullPointerException occurring in Java/Kotlin interop within the "RadTestContextProviderKt.chooseTargetForFile" function. The fix involves explicitly marking nullable return types in Java code using JetBrains annotations, which allows Kotlin to correctly infer and handle potential null values. This ensures robust null safety and prevents runtime errors when integrating Java and Kotlin components.

Highlights

• Java Nullability Annotations: Added "@NotNull" and "@Nullable" annotations to "ListenableFuture" return types in "SourceToTargetFinder.java" and "FuturesUtil.java" to accurately reflect potential null results, improving Java/Kotlin interop.
• Kotlin Null Safety Handling: Updated Kotlin code in "RadTestContextProvider.kt" to correctly handle nullable "ListenableFuture" results from Java by using "orEmpty()" to provide a default empty collection, preventing NPEs.
• Coroutine Refactoring: Replaced "async { ... }.asListenableFuture()" with the more concise "future { ... }" construct in "RadTestContextProvider.kt" for creating "ListenableFuture"s from coroutines.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[ujohnny]

/gemini review

[ujohnny]

/gemini review