bazelbuild
show squiggly line when import class not in build target
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g.
I signed it!) and we'll verify it.What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
I signed it!
Thanks for the pull request. I haven't had a chance to look over it yet, but will try to get to it within the next day or two.
Thanks again for the PR. I think the general approach of annotating missing imports/deps and providing a quick-fix action is good. Ideally, we wouldn't need to run a bazel build to find these.
We have a separate system for this internally. Bazel outputs a error with a suggested fix such as "Command to add missing dependencies: '[command line script]'". We add a hyperlink to the bazel console view (also linked in the bazel problems view) to run the script and apply the fix.
Otherwise, I'm not sure when we'd be able to work on this PR, since there's a fair bit of work involved applying it upstream. Some examples: I'd prefer to use buildozer directly rather than manually modifying BUILD files, the language-specific bits need to be moved to the appropriate modules, we'd need to add some tests and documentation, and make some style changes.
@brendandouglas - how do we proceed on this?
Ideally, we wouldn't need to run a bazel build to find these.
What are the alternatives?
We have a separate system for this internally.
Great! but we need to enrich this public plugin as well.. And this is our contribution to make it better and complete. Can you elaborate on the tool? is it something Wix can use?
Otherwise, I'm not sure when we'd be able to work on this PR, since there's a fair bit of work involved applying it upstream.
I'm a bit confused by this. What does it mean?
I'd prefer to use buildozer directly rather than manually modifying BUILD files, the language-specific bits need to be moved to the appropriate modules
See my suggestions here: #477 - would love to hear your comment . If you need our contribution here - we can do it.
we'd need to add some tests and documentation, and make some style changes.
What is the style guide? Where can we add documentation?
=== Bottom line - From the belief in bazel as a build tool and Intellij as our IDE, and from an Open Source approach - we are willing to work hard and contribute but we need your hand in this.
Would really like to know what are the concrete steps you want to do in order to push this plugin forward.
Thanks! cc: @ittaiz
@or-shachar, our preferred way of implementing this kind of feature would be via 'add_deps' support at bazel build time (there's some discussion of this in bazelbuild/bazel/issues/4846 and bazelbuild/bazel/issues/4584).
That moves responsibility for determining the appropriate fix to the build, rather than having a separate layer in the IDE. If that was implemented in bazel, we'd simply parse the relevant command in bazel's stdout/stderr, and add an entry to the 'bazel problems' view, as well as adding a link to the console output.
Otherwise, I'm not sure when we'd be able to work on this PR, since there's a fair bit of work involved applying it upstream.
I'm a bit confused by this. What does it mean?
This github project is just a mirror of our internal project. Applying patches involves:
- rewriting the PR to conform to our coding practices, style guide, etc.
- adding appropriate unit and integration tests and safeguards to lessen the chance of internal regressions, especially related to performance.
All of this takes time, so we prefer to iron out the details of a potential contribution beforehand, to save effort (see the 'contributions' section of the top level readme).
Hello @idankWix , If you are still looking to submit the above PR for review. Could you please resolve the code conflicts and fix the build checks. I can help you in arranging the review. Thanks!
Hello @idankWix , Above PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days, if no further activity occurs. Thank you!
Hi there! Thank you for contributing to the IntelliJ repository. We appreciate your time and effort. We're doing a clean up of old PRs and will be closing this one since it seems to have stalled. Please feel free to reopen/let us know if you’re still interested in pursuing this or if you'd like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.
