intellij icon indicating copy to clipboard operation
intellij copied to clipboard

Allow more characters in labels

Open ceason opened this issue 6 years ago • 2 comments

Bazel's LabelValidator class was updated in c4f2d80 to allow more characters in labels.

This PR updates TargetName validation to reflect those changes (specifically, it adds the following as valid characters: %'"&*;<>?[]{|}!`^).

ceason avatar Nov 25 '18 18:11 ceason

Hello @ceason, If you are still looking to submit the above PR for review. Could you please resolve the code conflicts and fix the build checks. I can help you in arranging the review. Thanks!

sgowroji avatar Sep 01 '22 08:09 sgowroji

Hello @ceason , Above PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days, if no further activity occurs. Thank you!

sgowroji avatar Sep 19 '22 06:09 sgowroji

Hi there! Thank you for contributing to the IntelliJ repository. We appreciate your time and effort. We're doing a clean up of old PRs and will be closing this one since it seems to have stalled. Please feel free to reopen/let us know if you’re still interested in pursuing this or if you'd like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

keertk avatar Dec 07 '22 19:12 keertk