intellij icon indicating copy to clipboard operation
intellij copied to clipboard

Integration with Protocol Buffers plugin

Open fkorotkov opened this issue 3 years ago • 4 comments

Checklist

  • [x] I have filed an issue about this change and discussed potential changes with the maintainers.
  • [x] I have received the approval from the maintainers to make this change.
  • [x] This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See the Contributions section in the README for more details.

Discussion thread for this change

Issue number: #3214

Description of this change

Integrate with Protocol Buffers plugin to provide resolution of external *.proto files.

fkorotkov avatar Feb 02 '22 16:02 fkorotkov

This PR is still missing tests that I will add if overall the change looks OK. @alice-ks PTAL

fkorotkov avatar Feb 02 '22 16:02 fkorotkov

Please see my feedback on the tracking issue (https://github.com/bazelbuild/intellij/issues/3214#issuecomment-1032989870).

alice-ks avatar Feb 08 '22 19:02 alice-ks

@alice-ks will you be OK merging changes to intellij_info_impl.bzl. This way I will be able to extract the rest in a separate plugin. Still not convenient but better then having a full fork of the plugin.

Having this generic_ide_info for each target is not a problem since there is no one huge aspect file for all the targets. There are just bunch of small aspect files which won't be significantly larger because of generic_ide_info.

fkorotkov avatar Apr 15 '22 01:04 fkorotkov

Hello @mai93, Could you please have a look on this PR and @fkorotkov comments. Thanks!

sgowroji avatar Sep 26 '22 04:09 sgowroji