intellij icon indicating copy to clipboard operation
intellij copied to clipboard

Fix and simplify opening of Bazel project using ProjectUtil.

Open avshenuk opened this issue 5 years ago • 3 comments

Checklist

  • [x] I have filed an issue about this change and discussed potential changes with the maintainers.
  • [ ] I have received the approval from the maintainers to make this change.
  • [x] This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See the Contributions section in the README for more details.

Discussion thread for this change

Issue number: https://github.com/bazelbuild/intellij/issues/2147

Description of this change

Opening Bazel project corrupts status bar widgets

avshenuk avatar Oct 25 '20 18:10 avshenuk

I know it's been a while, but it seems that the issue is not reproducible any more with IJ 2022.2

tpasternak avatar Aug 12 '22 15:08 tpasternak

Hello @avshenuk, Did you get a chance to verify the issue in the latest release as mentioned here https://github.com/bazelbuild/intellij/pull/2150#issuecomment-1213209743

sgowroji avatar Sep 19 '22 06:09 sgowroji

@sgowroji Yes, the status bar is not broken anymore. Thank you!

So the only feature this PR adds now is a modal dialogue asking which window the project should be opened in (current or new, as with regular projects). But you can close it if you think it's not worth it.

avshenuk avatar Sep 19 '22 06:09 avshenuk

Right, let's take it then!

tpasternak avatar Sep 26 '22 15:09 tpasternak

Thank you @avshenuk. Can you please rebase the PR for the CI tests to pass? Please check the error

mai93 avatar Sep 27 '22 19:09 mai93

@mai93 Done :)

avshenuk avatar Sep 28 '22 11:09 avshenuk

Thank you @avshenuk

tpasternak avatar Sep 28 '22 14:09 tpasternak