intellij icon indicating copy to clipboard operation
intellij copied to clipboard

fix expression quote

Open fujigon opened this issue 6 years ago • 4 comments

Checklist

  • [ ] I have filed an issue about this change and discussed potential changes with the maintainers.
  • [ ] I have received the approval from the maintainers to make this change.
  • [x] This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See the Contributions section in the README for more details.

Discussion thread for this change

Issue number: https://github.com/bazelbuild/intellij/issues/1540

Description of this change

quote change from " to ' for attr expression to avoid command failure on bash, zsh and on Windows.

fujigon avatar Jan 04 '20 05:01 fujigon

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jan 04 '20 05:01 googlebot

@googlebot I signed it!

fujigon avatar Jan 04 '20 05:01 fujigon

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Jan 04 '20 05:01 googlebot

Hello @fujigon, could you please resolve the code conflicts. Thanks!

sgowroji avatar Sep 19 '22 06:09 sgowroji

Hi there! Thank you for contributing to the IntelliJ repository. We appreciate your time and effort. We're doing a clean up of old PRs and will be closing this one since it seems to have stalled. Please feel free to reopen/let us know if you’re still interested in pursuing this or if you'd like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

keertk avatar Dec 07 '22 19:12 keertk