homebrew-tap
homebrew-tap copied to clipboard
bazelbuild
Add support for release candidates
Resolves issue #10. Might want to refactor a tiny bit so that upgrading the release candidate means only changing the version string and not the url.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
Is the build failure related to my pull request? If there's something I should change let me know.
Hi @kkiningh,
thanks, that looks pretty good! Don't worry about the test - I think our current Travis setup is a bit broken. I'll ping this PR when it should work again, so we can rerun the tests on this one (although I don't see any issues).
@kkiningh Sorry for the delay in merging :( Would you mind rebasing your PR? I'll merge it then! Otherwise I could also just apply your proposed changes to the current file myself (but then it wouldn't be in your name, so I wanted to check). Let me know. :)
Feel free to apply the changes yourself! I'm on vacation and won't be able to get to it until after Christmas.