Add support for mapped repository names in use_repo_add

[malt3]

Implement support for three types of repository specifications:

• Simple names: foo -> use_repo(ext, "foo")
• Mapped names with valid identifiers: bar=baz -> use_repo(ext, bar = "baz")
• Invalid identifiers use dict unpacking: foo.2=foo -> use_repo(ext, **{"foo.2": "foo"})

This follows the Bazel documentation recommendations for handling repository names that are not valid Starlark identifiers by using dictionary unpacking syntax.

[gemini-code-assist[bot]]

Summary of Changes

Hello @malt3, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the use_repo_add command within Buildozer by introducing support for mapped repository names. This allows users to define custom local names for external repositories, providing greater flexibility and control over Bazel module dependencies. The changes involve updating the command's parsing and generation logic to correctly handle different mapping syntaxes, including those with identifiers that are not valid Python names, and ensuring proper conflict resolution with existing repository declarations.

Highlights

• Enhanced use_repo_add functionality: The use_repo_add command now supports specifying mapped repository names, allowing for custom local names for imported repositories.
• Support for various mapping syntaxes: Repositories can be added using simple names (e.g., foo), mapped names with valid identifiers (e.g., bar=baz), or mapped names with invalid identifiers (e.g., foo.2=foo) which are handled via dictionary unpacking.
• Refactored AddRepoUsages logic: The core logic for adding repository usages has been updated to intelligently parse and apply these new mapping types, including conflict resolution for existing arguments.
• New helper functions: Introduced parseRepoMapping, isValidIdentifier, and addOrExtendDictUnpack to facilitate parsing, identifier validation, and dynamic dictionary manipulation for use_repo calls.
• Comprehensive test coverage: Extensive new test cases have been added to validate the correct behavior of mapped repository names, including edge cases and conflict scenarios.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[malt3]

/gemini review

[malt3]

/gemini review

[malt3]

/gemini review