`.bazeliskrc`: Add Support for Env Var and Tilde Expansion

Open albertocavalcante opened this issue 1 year ago • 1 comments

This is a proposal to add support for env expansion as os.MkdirAll will treat shell variables and ~ as literals.

Fixes https://github.com/bazelbuild/bazelisk/issues/586

Jun 25 '24 10:06 albertocavalcante

Hi @fweikert, could you or someone please review this PR when you have a chance? Thanks!

Jun 25 '24 10:06 albertocavalcante

Hey @fweikert, just wondering if you have any comments on this as I'm really keen to get this implemented and stop using a fork 😅. Thanks!

(Happy to change the else clause for an early return if makes more readable. I tried to follow my perception of the code "convention")

Jul 09 '24 15:07 albertocavalcante

Ah, I was too quick to merge. Yeah, I would have preferred an early return, too, but didn't want to block the PR on it.

Jul 09 '24 17:07 fweikert