bazelisk icon indicating copy to clipboard operation
bazelisk copied to clipboard

Add OS-specific BAZELISK_HOME

Open mzapotoczny opened this issue 2 years ago • 4 comments

BAZELISK_HOME should be set as absolute path, but all supported OSes use different folder structure. This might be a problem if we want to globally set BAZELISK_HOME for all developers.

Therefore we want to propose a change to add support for OS-specific BAZELISK_HOME, for example BAZELISK_HOME_WINDOWS.

mzapotoczny avatar Jun 14 '23 08:06 mzapotoczny

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 14 '23 08:06 google-cla[bot]

@fweikert could you take a look? Thanks in advance :)

mzapotoczny avatar Jun 20 '23 07:06 mzapotoczny

@fweikert - could you please have a look on that change ?

McAmun avatar Dec 04 '23 11:12 McAmun

@katre can you maybe help here ?

McAmun avatar Feb 27 '24 14:02 McAmun

@fweikert any update on this ?

McAmun avatar Jul 26 '24 09:07 McAmun

@fweikert @meteorcloudy - Can we get this merged please ? We would like to start using your official releases.

McAmun avatar Sep 05 '24 07:09 McAmun

@mzapotoczny thanks for this change, I took the liberty of resolving the merge conflict.

fweikert avatar Sep 06 '24 15:09 fweikert