bazelisk icon indicating copy to clipboard operation
bazelisk copied to clipboard

Update Bazel and all dependencies to latest

Open philwo opened this issue 1 year ago • 3 comments

We were lagging behind quite a bit, but this brings everything back to latest versions.

I manually verified that the change does not negatively affect the size of the generated binaries or the structure of the NPM package.

philwo avatar Aug 01 '22 09:08 philwo

Nice, thank you!

I triggered a rerun of the failing Windows test.

fweikert avatar Aug 01 '22 12:08 fweikert

Huh... that failure on Windows is strange:

compilepkg: could not create directory for empty.go: mkdir C:\b\2hhx3mgx\execroot_main\bazel-out\x64_windows-fastbuild\bin\platforms\github_com_bazelbuild_bazelisk_platforms: Cannot create a file when that file already exists.

I don't immediately have an idea what might cause it, but I can try a few things in this PR later or in the next days to fix this.

philwo avatar Aug 02 '22 05:08 philwo

The error seemed to be through at https://github.com/bazelbuild/rules_go/blob/ed56d7e5b6a7bf833169372742c1ff72f501846a/go/tools/builders/compilepkg.go#L206-L208, if I try to build //platforms:platforms_test alone, it doesn't throw the error. I think there is some conflict between actions.

meteorcloudy avatar Sep 02 '22 14:09 meteorcloudy

Closing in favor of https://github.com/bazelbuild/bazelisk/pull/403

fweikert avatar Dec 15 '22 12:12 fweikert