Run go vet as presubmit check

Open fweikert opened this issue 5 years ago • 2 comments

This commit runs go vet with shadowing detection (among other checks) during presubmits in order to prevent variable shadowing, which caused #185.

Note: The shadowing check is no longer part of go vet by default, hence we need to run three commands instead of a single "go vet".

Oct 19 '20 14:10 fweikert

Just FYI, the Windows-presubmit passes now :)

Oct 20 '20 15:10 philwo

Thanks! I still need to investigate why the "go vet" presubmit is NOT failing :(

Oct 20 '20 15:10 fweikert