bazel icon indicating copy to clipboard operation
bazel copied to clipboard

[9.0.0] Add type param to repository_ctx.extract()

Open meteorcloudy opened this issue 2 weeks ago • 1 comments

Before, you had to rename or symlink a file to the correct compressed/archived file extension in order for it to be decompressed properly. Now you can specify rhe type of the file explicitly, without renaming/symlinking.

In other words, before, this wouldn't work, because the file type could not be determined:

repository_ctx.extract("my_archive")

Now you can set a type (the archive is zipped):

repository_ctx.extract("my_archive", type="zip")

Fixes: #26254


The first commit does some refactoring before adding the feature. This change will merge conflict with #27413 - I'll update once that is merged.

Closes #27423.

PiperOrigin-RevId: 842655968 Change-Id: Iea9e3fd458229a7cdd8f6a076eb594d82d61b5b0

meteorcloudy avatar Dec 10 '25 13:12 meteorcloudy

Summary of Changes

Hello @meteorcloudy, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the repository_ctx.extract() function by introducing an optional type parameter. This new parameter allows users to explicitly define the archive format for decompression, eliminating the previous reliance on file extensions for format detection. This change provides greater flexibility, especially for archives with non-standard naming, and improves the robustness of external repository rule definitions.

Highlights

  • Explicit Archive Type Specification: The repository_ctx.extract() function now accepts an optional type parameter, allowing users to explicitly specify the archive format (e.g., "zip", "tar.gz") for decompression.
  • Improved Flexibility: This change eliminates the previous requirement for archives to have specific file extensions for proper format detection, providing greater flexibility when handling files with non-standard naming conventions.
  • Decompressor Logic Refactoring: The internal decompressor lookup logic has been refactored for better maintainability and extensibility, using structured lists of supported formats.
  • Documentation and Test Coverage: New tests have been added to ensure consistency between the supported format documentation in Java and Starlark, and to validate the functionality of the new type parameter.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 10 '25 13:12 gemini-code-assist[bot]