bazel icon indicating copy to clipboard operation
bazel copied to clipboard

[8.3.0] Add strip_include_prefix to cc_import

Open iancha1992 opened this issue 6 months ago • 4 comments

Fixes https://github.com/bazelbuild/bazel/issues/4748

Closes #25710.

PiperOrigin-RevId: 770991345 Change-Id: Ib9af3561acbe0e34624031ee2cf4f0dcbddf4bff

Commit https://github.com/bazelbuild/bazel/commit/9f4448f9ee62a1041030a8fa6b4add2ad7b228c7

iancha1992 avatar Jun 13 '25 17:06 iancha1992

Something's wrong. Lemme take a look

iancha1992 avatar Jun 13 '25 21:06 iancha1992

@fmeum @pzembrod @meteorcloudy @Wyverald We have src/main/starlark/tests/builtins_bzl/cc/cc_static_library/test/BUILD.builtin_test in the master, but in the release-8.3.0, we have src/main/starlark/tests/builtins_bzl/cc/cc_static_library/test_cc_static_library/BUILD.builtin_test

Is that intended or did we forget to push this revert on the master?: https://github.com/bazelbuild/bazel/pull/24522

iancha1992 avatar Jun 13 '25 22:06 iancha1992

Hmm, @fmeum Should we also apply https://github.com/bazelbuild/bazel/pull/24522 to the master branch?

meteorcloudy avatar Jun 16 '25 12:06 meteorcloudy

@iancha1992 Thanks for catching this, I sent https://github.com/bazelbuild/bazel/pull/26313 to revert this on master.

fmeum avatar Jun 16 '25 12:06 fmeum