bazel
bazel copied to clipboard
bazelbuild
Enable timeout propagation for remote actions
When building using remote execution, action timeouts sometimes need to be adjusted per action to ensure reasonable timeouts are set.
This change will allow better control over how actions behave and encourage users to optimize their actions since the global default timeout does not have to be set to the absolute largest action timeout in the graph.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @quic-sbjorkle, Could you please sign the CLA.
@sgowroji Should be signed now if you retrigger the check.
I'm supportive of this PR in principle, but I need to do some due diligence to verify that reinterpreting an existing timeout tag won't cause problems at Google.
For triaging purposes -- is this fixing a regression introduced in an earlier 8.0.0 RC?
If not, this need not be release-blocking, but we can certainly cherry-pick to 8.1.0 at least.
@tjgq Are there any more changes needed from my side, or is it good to go now?
Sorry, I'm about to be out of office, so I won't have time to look into this until January. I would also like @zhengwei143 to do a review of his own.
What's the status of this PR?
I had some issues understanding the proper places where to place unit-tests so they actually verify the remote execution requirements. And then I haven't had time to pick it up again. I will try to squeeze in some time to finish this up before summer.