bazel icon indicating copy to clipboard operation
bazel copied to clipboard

Wire up `internal-inline-outputs` requirement with RE API

Open fmeum opened this issue 1 year ago • 1 comments

In-memory outputs marked with the internal-inline-outputs execution requirement are now added to the inline_output_files hint field of the remote execution and remote cache API, potentially saving a round trip on files that are unconditionally read by Bazel client after spawn execution.

Support for output file inlining has been added to the remote worker implementation.

Work towards #8421

fmeum avatar Aug 26 '24 20:08 fmeum

Currently stacked on https://github.com/bazelbuild/bazel/pull/23421, but otherwise ready for review.

fmeum avatar Aug 27 '24 09:08 fmeum

FYI, the changes to remote_execution.proto must be sent in a separate PR. I can do that tomorrow if you don't beat me to it.

tjgq avatar Aug 28 '24 17:08 tjgq

@tjgq I sent https://github.com/bazelbuild/bazel/pull/23458

fmeum avatar Aug 28 '24 19:08 fmeum

@tjgq I updated this to say "Fixes #8421" as it realizes inlining for the cases that were originally anticipated. I think it's better to open a dedicated issue for the potential extension to arbitrary outputs.

fmeum avatar Aug 29 '24 10:08 fmeum

@tjgq I updated this to say "Fixes #8421" as it realizes inlining for the cases that were originally anticipated. I think it's better to open a dedicated issue for the potential extension to arbitrary outputs.

Per the recent discussion in that issue, I agree.

tjgq avatar Aug 29 '24 13:08 tjgq

@bazel-io fork 7.4.0

fmeum avatar Sep 04 '24 14:09 fmeum

@tjgq @fmeum can you please resolve the conflicts?

iancha1992 avatar Sep 06 '24 18:09 iancha1992

@tjgq @fmeum can you please resolve the conflicts?

@tjgq @fmeum Friendly ping :)

iancha1992 avatar Sep 10 '24 21:09 iancha1992

I will do the import and resolve the conflicts.

tjgq avatar Sep 11 '24 14:09 tjgq