bazel icon indicating copy to clipboard operation
bazel copied to clipboard

[7.4.0] Let repo rule attributes reference extension apparent names

Open bazel-io opened this issue 1 year ago • 1 comments

Forked from #23369

bazel-io avatar Aug 22 '24 19:08 bazel-io

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java src/main/java/com/google/devtools/build/lib/bazel/bzlmod/SingleExtensionEvalFunction.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionResolutionTest.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/TypeCheckedTagTest.java

cc: @bazelbuild/triage

bazel-io avatar Aug 23 '24 19:08 bazel-io

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionEvalStarlarkThreadContext.java src/main/java/com/google/devtools/build/lib/bazel/bzlmod/SingleExtensionEvalFunction.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/ModuleExtensionResolutionTest.java src/test/java/com/google/devtools/build/lib/bazel/bzlmod/TypeCheckedTagTest.java

cc: @bazelbuild/triage

cc: @fmeum @Wyverald @meteorcloudy

iancha1992 avatar Aug 28 '24 22:08 iancha1992

@Wyverald Could you help cherry-pick this? It looks like there are a number of refactoring commits missing (AutoValue -> record, module thread context extraction, ...) but I don't know which ones exactly.

fmeum avatar Sep 19 '24 09:09 fmeum

uh, apparently I already did that last week... 😅 https://github.com/bazelbuild/bazel/pull/23585

Wyverald avatar Sep 19 '24 20:09 Wyverald