bazel icon indicating copy to clipboard operation
bazel copied to clipboard

BEP: Sets `start_time` on `BuildStarted` events from `NoBuildEvent`

Open iamricard opened this issue 1 year ago • 2 comments

When handling invocations we noticed some invocations still weren't setting start_time on BuildStarted. We specifically noticed this on build event streams from query invocations. After some spelunking I found NoBuildEvent, which didn't get updated with the rest of the codebase in e5c832a16e475f636c845b0247731f65df5e258c.

cc @lfpino

iamricard avatar May 15 '24 10:05 iamricard

Hi @iamricard  Could you please sign the CLA?

sgowroji avatar May 29 '24 05:05 sgowroji

I have signed it.

image

iamricard avatar May 29 '24 22:05 iamricard

bump @sgowroji

iamricard avatar Jun 10 '24 16:06 iamricard

I have signed it.

image

@Yannic Can you also sign your contribution?

saraadams avatar Aug 06 '24 12:08 saraadams

@sgowroji I amended the commit to use Yannic's EngFlow email

iamricard avatar Aug 06 '24 12:08 iamricard