bazel icon indicating copy to clipboard operation
bazel copied to clipboard

[7.2.0] `bazel build //X:all` records target completion events in the BEP stream with `file://` URIs, but sometimes doesn't write files to disk

Open bazel-io opened this issue 1 year ago • 4 comments

Forked from #20737

bazel-io avatar Jan 09 '24 18:01 bazel-io

/cc @coeuvre adding this one as a soft release blocker, let me know if this should actually block the release!

meteorcloudy avatar Feb 08 '24 17:02 meteorcloudy

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/skyframe/AspectCompletor.java src/main/java/com/google/devtools/build/lib/skyframe/BUILD src/main/java/com/google/devtools/build/lib/skyframe/CompletionFunction.java src/main/java/com/google/devtools/build/lib/skyframe/SkyframeExecutor.java src/main/java/com/google/devtools/build/lib/skyframe/TargetCompletor.java

cc: @bazelbuild/triage

bazel-io avatar May 10 '24 09:05 bazel-io

Cherry-picked in https://github.com/bazelbuild/bazel/pull/22318 by @coeuvre

iancha1992 avatar May 10 '24 18:05 iancha1992

Unfortunately, the change was reverted in HEAD because it broke one of our internal test (not sure why the test was not triggered by the presubmit though). I will work on fix and patch it on the 7.2.0.

coeuvre avatar May 13 '24 11:05 coeuvre

Will close this once https://github.com/bazelbuild/bazel/pull/22348 is merged

iancha1992 avatar May 13 '24 15:05 iancha1992